[WP-34s] Add radix in show digits of x display

[Jonathan Cameron]

If you want to see all the digits in a number using the [f][<] command, the WP-34s will show some of the digits in the upper display and the rest in the lower. Unfortunately, it omits the radix (decimal point or comma). I've put together a patch that addresses this for both single-precision mode and double-precision mode. This patch inserts the correct radix depending on the current radix mode.

The changes only affect the function show_x() in display.c. This patch is for the WP-34s trunk. But it should also work as-is in the WP-31s code. Since the patch is for the WP-34s code, I've included the updated show_x() function code in the attached show_x.c file to make it simpler to apply (if the patch program has any difficulties with the patch file). The code is the same for both, but the double-precision mode parts of the code will never be exercised in the WP-31s version.

Here is what the display looks with PI in single precision mode:


In double-precisoin mode, the display for the left part of PI looks like this:


and the right part looks like this (no radix is displayed):


Please give it a try and let me know if you encounter any problems with it. If it seems okay, I can incorporate it into both the WP-34s and WP-31s code.

You can download versions for testing at:

http://jmcameron.net/WP-34s/downloads/

-Jonathan

[Paul Dale]

What is the exponent doing there? In double precision, the exponent can have four digits.

Walter thought a bit about laying this display mode out -- he'll need to consider and comment before we commit this change.


Still, a nice effort.


- Pauli

[Marcus von Cube]

(03-16-2014 08:31 AM)Paul Dale Wrote:  What is the exponent doing there? In double precision, the exponent can have four digits.

The first image is for single precision, the second and third show double precision. The four digit exponent is shown in picture 2. I see no problems here. I think the only change is in the first line of the display, not the second.

We have to check how it looks without the nice fonts of the Qt GUI but I don't have any objections.

[Jonathan Cameron]

(03-16-2014 09:55 AM)Marcus von Cube Wrote:  

(03-16-2014 08:31 AM)Paul Dale Wrote:  What is the exponent doing there? In double precision, the exponent can have four digits.

The first image is for single precision, the second and third show double precision. The four digit exponent is shown in picture 2. I see no problems here. I think the only change is in the first line of the display, not the second.

We have to check how it looks without the nice fonts of the Qt GUI but I don't have any objections.

Yes, the only changes are for the upper line. And it is strictly to insert the radix after the first character. The code assumes that the number is being put into "scientific" mode and hence the radix will always be at the same location.

-Jonathan

[walter b]

No objections from my side if it works as advertized which I'm afraid I cannot test for the next week.

d:-)

[Jonathan Cameron]

If you would like to flash this update on your WP-34s to test it, here is a binary image with this fix in the attached zip file (without libraries, svn version 3556).

[EDIT] I have put several flash images on my site so you can download them to test them. So I deleted the attachment to this post. You can download the test version from here:

http://jmcameron.net/WP-34s/downloads/

-Jonathan

[Jonathan Cameron]

I had a request for a version of the flash image for the 30b with libraries and crystal support, so I've put together several different versions at (sorry no IR versions):

http://jmcameron.net/WP-34s/downloads/

I've been testing this on the WP-34s (HP 30b) hardware as well as the Linux Qt Emulator and it seems to work okay as far as i can tell.

I encourage others to test it and let me know how it works for you---especially if you encounter oddities.

-Jonathan