Threaded Mode | Linear Mode

Thomas Klemm · 09-13-2015, 11:10 AM

From Programming Handheld Calculators by Paul Lutus.

[Image: pos1.jpg]

Dieter · (This post was last modified: 09-20-2015 08:58 PM by Dieter.)

(09-13-2015 11:10 AM)Thomas Klemm Wrote: From Programming Handheld Calculators by Paul Lutus.

Could you take a look at line 101? The code there is...

Code:

 97 1

 98 RCL (i)

 99 FRAC

100 STO 3

101 -

102 1

103 RCL 3

104 -

105 /

This calculates (1–R3)/(1–R3) which is always 1. ;-)
I think line 101 should read "+".

I also assume that "lbl A", "lbl B", "lbl C" and "lbl D" in the user instructions (table 3) are supposed to mean simply "A", "B", "C" and "D".
Typing a label instruction in run mode does not do anything. ;-)

Finally there are some "TF" commands. This was a HP65 instruction. On the HP67/97 testing flags is done with the "F?" command. I hope the program considers the 67/97's special behaviour of Flag 2 tests. ;-)

Dieter

Thomas Klemm · 09-20-2015, 09:47 PM

(09-20-2015 08:53 PM)Dieter Wrote: Could you take a look at line 101? The code there is...

Code:

97 1 98 RCL (i) 99 FRAC 100 STO 3 101 - 102 1 103 RCL 3 104 - 105 /

This calculates (1–R3)/(1–R3) which is always 1. ;-)
I think line 101 should read "+".

It appears that these lines calculate \(\frac{1+e}{1-e}\) of the formula in the mentioned article.

Quote:I also assume that "lbl A", "lbl B", "lbl C" and "lbl D" in the user instructions (table 3) are supposed to mean simply "A", "B", "C" and "D".
Typing a label instruction in run mode does not do anything. ;-)

Finally there are some "TF" commands. This was a HP65 instruction. On the HP67/97 testing flags is done with the "F?" command. I hope the program considers the 67/97's special behaviour of Flag 2 tests. ;-)

I haven't tested this program. But Paul Lutus mentioned that there were errors both in the listing and the data:

Quote:As with the solar position program, the article's publication created a lot of correspondence, including inquiries from JPL and its consultants asking about mathematical details and correcting some errors in the original published data tables (example).

It would be cool if we could make this program run correctly.

Cheers
Thomas

Dieter · 09-20-2015, 10:00 PM

(09-20-2015 09:47 PM)Thomas Klemm Wrote: It appears that these lines calculate \(\frac{1+e}{1-e}\) of the formula in the mentioned article.

Yes, that's why I think there must be a "+" instead of a "–" in line 101.

(09-20-2015 09:47 PM)Thomas Klemm Wrote: I haven't tested this program. But Paul Lutus mentioned that there were errors both in the listing and the data:
...
It would be cool if we could make this program run correctly.

This should be no problem with a simple image editor. ;-)
Or maybe a HP97 user provides a (corrected) printed listing.

I do not know anything about astronomy, so maybe someone who is more into this could check the program as well as its data set, and post some results it returns. Or those it should return. ;-)

Dieter

Josef · (This post was last modified: 08-04-2023 08:40 AM by Josef.)

I tested the program and found that it contains multiple bugs. Some of the errors are due to bad copy, and some are due to using incorrectly marked functions. The algorithm is quite simple and quite inaccurate. I also analyzed the program's data which contains the major planet semi-axis, orbital period and longitude of perihelion in the order of Earth, Mercury, Venus, Mars, Jupiter and Saturn. Subsequently, we can replace them with Uranus, Neptune and Pluto. I've modified the program, and at least it works reasonably. The printed version doesn't even calculate Century Day correctly, which is a prerequisite for correct calculations. There are reasonably good astronomy programs for HP 50g, and I have been able to modify some of them to work.

Here is a listing of the modified program for the HP-67.

Code:

  31 25 11     LBL A

     33 00     STO 0

  33 51 00     STO-0

     33 01     STO 1

     31 83       INT

  33 51 01     STO-1

        01         1

        51         -

        02         2

     32 71      XLEY

  33 51 00     STO-0

     32 71      XLEY

  35 51 02      SF 2

     35 53      R DN

        03         3

        00         0

        83         .

        05         5

        08         8

        71         x

     23 02     DSP 2

     31 24       RND

  33 61 00     STO+0

     34 01     RCL 1

        43       EEX

        02         2

        71         x

        41     ENTER

     31 83       INT

  33 61 00     STO+0

        51         -

        03         3

        06         6

        05         5

        02         2

        05         5

        71         x

        41     ENTER

     31 83       INT

  33 61 00     STO+0

        51         -

  35 71 02      F? 2

     22 00     GTO 0

     31 61      XNE0

     22 00     GTO 0

        01         1

  33 51 00     STO-0

  31 25 00     LBL 0

     34 00     RCL 0

     23 02     DSP 2

     35 22       RTN

  31 25 12     LBL B

        00         0

     33 01     STO 1

     33 02     STO 2

        04         4

  35 51 02      SF 2

     22 01     GTO 1

  31 25 14     LBL D

        01         1

        07         7

     22 01     GTO 1

  31 25 15     LBL E

        02         2

        02         2

     22 01     GTO 1

  32 25 11    LBL fa

        08         8

     22 01     GTO 1

  32 25 12    LBL fb

        01         1

        01         1

     22 01     GTO 1

  32 25 13    LBL fc

        01         1

        04         4

  31 25 01     LBL 1

     35 33      ST I

     34 00     RCL 0

     34 24   RCL (i)

     32 83      FRAC

        43       EEX

        05         5

        71         x

        51         -

     31 34       ISZ

     34 24   RCL (i)

  31 22 08     GSB 8

        41     ENTER

     31 34       ISZ

     34 24   RCL (i)

     31 83       INT

        51         -

        02         2

        81         /

     31 64       TAN

        01         1

     34 24   RCL (i)

     32 83      FRAC

     33 03     STO 3

        61         +

        01         1

     34 03     RCL 3

        51         -

        81         /

        71         x

     32 64     TAN-1

        02         2

        71         x

        41     ENTER

     31 63       COS

     34 03     RCL 3

        71         x

        01         1

        51         -

        01         1

     34 03     RCL 3

     32 54       x^2

        51         -

     35 52      X<>Y

        81         /

     35 52      X<>Y

     34 24   RCL (i)

     31 83       INT

        51         -

     35 52      X<>Y

     31 33       DSZ

     31 33       DSZ

     34 24   RCL (i)

     31 83       INT

        43       EEX

        04         4

        81         /

        71         x

     31 72       R<P

  35 71 02      F? 2

     22 02     GTO 2

     33 01     STO 1

     35 52      X<>Y

     33 02     STO 2

        04         4

  35 51 02      SF 2

     22 01     GTO 1

  31 25 02     LBL 2

  33 51 01     STO-1

     35 52      X<>Y

  33 51 02     STO-2

     34 02     RCL 2

     34 01     RCL 1

     32 72       R>P

     35 52      X<>Y

     31 71      XLT0

  31 22 07     GSB 7

        41     ENTER

     33 03     STO 3

        02         2

        71         x

     31 62       SIN

        02         2

        83         .

        04         4

        71         x

        51         -

  35 71 00      F? 0

  31 22 09     GSB 9

     32 74    H>H.MS

        84       R/S

     34 03     RCL 3

     31 62       SIN

        02         2

        03         3

        83         .

        05         5

        71         x

     32 74    H>H.MS

        84       R/S

     35 54      R UP

     35 22       RTN

  31 25 07     LBL 7

        03         3

        06         6

        00         0

        61         +

     35 22       RTN

  31 25 08     LBL 8

        81         /

     32 83      FRAC

        03         3

        06         6

        00         0

        71         x

     35 22       RTN

  31 25 13     LBL C

     34 00     RCL 0

        02         2

        00         0

        83         .

        06         6

        61         +

     34 07     RCL 7

  31 22 08     GSB 8

  35 71 00      F? 0

  31 22 09     GSB 9

     32 74    H>H.MS

     35 22       RTN

  31 25 09     LBL 9

        01         1

        05         5

        81         /

     35 22       RTN

  32 25 15    LBL fe

        00         0

  35 71 00      F? 0

     22 00     GTO 0

  35 51 00      SF 0

  31 22 07     GSB 7

     22 09     GTO 9

  31 25 00     LBL 0

  35 61 00      CF 0

     22 07     GTO 7

Thomas Klemm · 08-06-2023, 01:06 PM

That's great!
From what I can see you additionally changed the following lines:

Code:

021:     23 02     DSP 2

115:        51         -

I took your program, added the data in the registers and pasted it in this HP-67 emulator:

Code:

PROG

224

 31 25 11

 33 00

 33 51 00

 33 01

 31 83

 33 51 01

 01

 51

 02

 32 71

 33 51 00

 32 71

 35 51 02

 35 53

 03

 00

 83

 05

 08

 71

 23 02

 31 24

 33 61 00

 34 01

 43

 02

 71

 41

 31 83

 33 61 00

 51

 03

 06

 05

 02

 05

 71

 41

 31 83

 33 61 00

 51

 35 71 02

 22 00

 31 61

 22 00

 01

 33 51 00

 31 25 00

 34 00

 23 02

 35 22

 31 25 12

 00

 33 01

 33 02

 04

 35 51 02

 22 01

 31 25 14

 01

 07

 22 01

 31 25 15

 02

 02

 22 01

 32 25 11

 08

 22 01

 32 25 12

 01

 01

 22 01

 32 25 13

 01

 04

 31 25 01

 35 33

 34 00

 34 24

 32 83

 43

 05

 71

 51

 31 34

 34 24

 31 22 08

 41

 31 34

 34 24

 31 83

 51

 02

 81

 31 64

 01

 34 24

 32 83

 33 03

 61

 01

 34 03

 51

 81

 71

 32 64

 02

 71

 41

 31 63

 34 03

 71

 01

 51

 01

 34 03

 32 54

 51

 35 52

 81

 35 52

 34 24

 31 83

 51

 35 52

 31 33

 31 33

 34 24

 31 83

 43

 04

 81

 71

 31 72

 35 71 02

 22 02

 33 01

 35 52

 33 02

 04

 35 51 02

 22 01

 31 25 02

 33 51 01

 35 52

 33 51 02

 34 02

 34 01

 32 72

 35 52

 31 71

 31 22 07

 41

 33 03

 02

 71

 31 62

 02

 83

 04

 71

 51

 35 71 00

 31 22 09

 32 74

 84

 34 03

 31 62

 02

 03

 83

 05

 71

 32 74

 84

 35 54

 35 22

 31 25 07

 03

 06

 00

 61

 35 22

 31 25 08

 81

 32 83

 03

 06

 00

 71

 35 22

 31 25 13

 34 00

 02

 00

 83

 06

 61

 34 07

 31 22 08

 35 71 00

 31 22 09

 32 74

 35 22

 31 25 09

 01

 05

 81

 35 22

 32 25 15

 00

 35 71 00

 22 00

 35 51 00

 31 22 07

 22 09

 31 25 00

 35 61 00

 22 07

 84

 84

 84

 84

DATA

26

 0

 0

 0

 0

 10000.00102

 365.2564

 102.0167

 27.321661

 3871.000434

 87.9693

 77.20563

 7233.002141

 224.7009

 131.006784

 15237.01249

 686.9796

 335.093384

 52022.02874

 4332.0446

 14.04795

 0

 0

 95691.08041

 10775.056

 93.05741

 4

STATE

7

DEG

FIX

2

1

0

0

1

HELP

1

CARD

11

Title: Planetary Ephemeris

A: Date

B: Sun

C: Moon

D: Jupiter

E:

a:

b:

c:

d:

e: 24/360

END

Example

I just followed the example in table 3:

10.1277 A
28409.22

B
22.37

C
13.26

D
6.45

R/S
23.06

R/S
4.72

This looks quite good already.
But the result for the Sun is totally off.

In a comment it says that "10.1277 is the date of a solar eclipse".
Therefore I assume that the Sun's and Moon's position should agree.

Do you have any idea what's going wrong?

Josef · 08-07-2023, 10:24 AM

Yes, you have a right. I am now preparing a much better version of the calculation of the Sun's position that is significantly more accurate. Unfortunately, fitting the positions of the planets and Sun into one program in 224 steps with reasonable accuracy is impossible. The author did not give the exact algorithm for calculating the positions, it could be reverse decoded, but it is better to write the program again and better.

Josef · 09-01-2023, 01:02 PM

I also tested the calculations for Mercury and Venus, they are completely off, they just don't work. I have prepared new calculations of planetary positions according to other algorithms and allow calculations for years higher than 1999, which the above program does not allow.