Trying to improve x49gp

[gwh]

(11-17-2021 11:02 PM)3298 Wrote:  

(11-17-2021 09:52 PM)gwh Wrote:  It also adds DESTDIR in the Makefile because I make a (Slackware) package and this makes it easier.

Uhh, so where's the problem this is supposed to solve that isn't already solved by overriding INSTALL_PREFIX (see the Arch PKGBUILD I attached to an earlier post in this thread)?
In short, I run make all with INSTALL_PREFIX set to where it's supposed to be installed eventually (so the handful of directory references compiled into the binary are correct), then make install with INSTALL_PREFIX set to the equivalent directory inside the one that gets compressed into a package by the packaging utility. That's the kind of process I've seen in packaging other software, and therefore the process I designed the INSTALL_PREFIX variable for when I implemented the install target.

Not a problem per se. I missed your PKGBUILD posted earlier.

In my opinion (and really I'm just splitting hair and rationalizing), what I came to understand packaging sources is that INSTALL_PREFIX defines where is the target filesystem the files should be installed. DESTDIR is a temporary prefix added only during the make install phase. It's not used anywhere else, whereas I've seen software where INSTALL_PREFIX (or more precisely PREFIX) was significant during compilation and overriding it during make install broke something.
Nothing wrong in this case with your approach but it could cause problems with different software and the convention I internalized regarding Makefiles is more along the lines of

Code:


make PREFIX=/usr
make install PREFIX=/usr DESTDIR=$PKG

or when there's a ./configure involved

Code:


./configure --prefix=/usr
make
make install DESTDIR=$PKG

[/code][/php]