Post Reply 
Free42 state file switching, export, and import
08-18-2019, 09:43 AM
Post: #8
RE: Free42 state file switching, export, and import
Hi Thomas,

Wow, that are many changes to the source! That must have been a lot of time that you invested in such a "small" feature and everything for free and open source! Thank you!

Here are a few remarks after compiling Free42 under Arch Linux:

  1. Arch Linux requires the X11 library as well (LIBS += -lX11). Probably all Linux distributions require it.
  2. At least under Arch Linux -Wno-narrowing is necessary. As you've added it to the FreeBSD and SunOS builds, can you please add it to the normal Linux build as well? I think there are no downsides.
  3. Speaking of compile options: Adding -Wno-missing-braces -Wno-unused-but-set-variable -Wno-unused-variable removes hundreds of warnings.
  4. The buffer for the path generation in gtk/ is too small:
    Code: warning: '%s' directive output may be truncated writing up to 255 bytes into a region of size between 0 and 255 [-Wformat-truncation=]
      384 |         snprintf(core_state_file_name, FILENAMELEN, "%s/%s.f42", free42dirname, state.coreName);
          |                                                         ^~                      ~~~~~~~~~~~~~~ note: 'snprintf' output between 6 and 516 bytes into a destination of size 256
      384 |         snprintf(core_state_file_name, FILENAMELEN, "%s/%s.f42", free42dirname, state.coreName);
          |         ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~​~~~~~~~~~~~~
    You are trying to put two strings with a length of up to 255 characters in a buffer of only 255 characters. There are several places with this issue.
  5. There are some misleading-indentation warnings like
    Code: In function 'void keydown_normal_mode(int, int)': warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     1821 |             else if (prgms[current_prgm].text[pc] != CMD_END)
          |                  ^~ note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
     1823 |                 prgm_highlight_row = 1;
          |                 ^~~~~~~~~~~~~~~~~~
Visit this user's website Find all posts by this user
Quote this message in a reply
Post Reply 

Messages In This Thread
RE: Free42 state file switching, export, and import - SammysHP - 08-18-2019 09:43 AM

User(s) browsing this thread: 1 Guest(s)