Post Reply 
WP 34S and 31S bugs and fixes
11-26-2014, 05:24 AM (This post was last modified: 11-26-2014 05:28 AM by Bit.)
Post: #10
RE: WP 34S and 31S bugs and fixes
I've found another issue related to prime numbers. NEXTP increments a number in a loop but if the value is large enough, there aren't enough digits in the mantissa for the number to actually increase. For X ≥ 263, the recently fixed PRIME? command produces an error. But in single precision mode if 9999999999999937 ≤ X < 263, the XROM code gets stuck in an infinite loop and the calculator has to be reset.

I've updated NEXTP, and now it gives a domain error instead of hanging in such cases. If it's invoked in single precision mode (or on the 31S), it fails if the input is greater than or equal to 9999999999999937 (the largest prime that can be accurately represented in single precision mode). Without that, it'd produce incorrectly rounded values when returning from double precision mode via xOUT. For example, NEXTP 1017 would return 1017, which is neither the next number, nor a prime. The new version uses xIN that helps properly recover from errors reported by PRIME? and handle truncating in integer mode. The only library function that invokes NEXTP is PF, which doesn't use xIN, so there are no conflicts due to nesting.

This issue highlighted another problem: XROM code couldn't be interrupted. Other similar bugs in XROM may exist or could be introduced later, so it'd be useful if there was a more graceful way of dealing with them than a hardware reset. Therefore I created a feature to interrupt XROM code safely by holding down the EXIT/ON key for a while. A variable (OnKeyTicks) in volatile RAM indicates how long the EXIT key has been held down and xeq() generates an error ("Interrupted") above a certain threshold. It's a compile time option and I recommend that it be enabled in all builds, but I left it disabled by default until it's approved by one of the original developers.

Pascal, I've added support for this feature in the Qt versions. They seem to work on Linux but please have a look.

To make testing easier for those who can't compile binaries, I've attached 34S and 31S builds that interrupt XROM code if the EXIT key is held down for 1 second, and they include the old NEXTP implementation that locks up if X = 1017 in single precision mode. (The binaries were compiled from vanilla r3700 sources without any of my other patches.)


Attached File(s)
.zip  XROM_interrupt_test_r3700.zip (Size: 151.05 KB / Downloads: 5)
Find all posts by this user
Quote this message in a reply
Post Reply 


Messages In This Thread
WP 34S and 31S bugs and fixes - Bit - 11-22-2014, 07:49 PM
RE: WP 34S and 31S bugs and fixes - Bit - 11-23-2014, 06:48 PM
RE: WP 34S and 31S bugs and fixes - Bit - 11-24-2014, 02:21 AM
RE: WP 34S and 31S bugs and fixes - Bit - 11-25-2014, 05:11 AM
RE: WP 34S and 31S bugs and fixes - Bit - 11-26-2014 05:24 AM
RE: WP 34S and 31S bugs and fixes - Bit - 11-26-2014, 01:35 PM
RE: WP 34S and 31S bugs and fixes - Bit - 11-26-2014, 01:38 PM
RE: WP 34S and 31S bugs and fixes - Bit - 11-26-2014, 07:56 PM
RE: WP 34S and 31S bugs and fixes - Bit - 11-27-2014, 02:13 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-31-2015, 01:32 AM
RE: WP 34S and 31S bugs and fixes - Bit - 11-29-2014, 08:31 PM
RE: WP 34S and 31S bugs and fixes - Bit - 12-06-2014, 03:23 AM
RE: WP 34S and 31S bugs and fixes - Bit - 12-06-2014, 03:02 PM
RE: WP 34S and 31S bugs and fixes - Bit - 12-07-2014, 09:38 PM
RE: WP 34S and 31S bugs and fixes - Bit - 12-12-2014, 03:20 PM
RE: WP 34S and 31S bugs and fixes - Bit - 12-06-2014, 08:44 PM
RE: WP 34S and 31S bugs and fixes - Bit - 12-07-2014, 10:01 PM
RE: WP 34S and 31S bugs and fixes - Bit - 12-08-2014, 03:38 PM
RE: WP 34S and 31S bugs and fixes - Bit - 12-08-2014, 05:19 PM
RE: WP 34S and 31S bugs and fixes - Bit - 12-08-2014, 05:49 PM
RE: WP 34S and 31S bugs and fixes - Bit - 12-08-2014, 06:34 PM
RE: WP 34S and 31S bugs and fixes - Bit - 12-16-2014, 02:57 AM
RE: WP 34S and 31S bugs and fixes - Bit - 12-24-2014, 01:09 PM
RE: WP 34S and 31S bugs and fixes - Bit - 12-24-2014, 02:36 PM
RE: WP 34S and 31S bugs and fixes - Bit - 12-24-2014, 04:30 PM
RE: WP 34S and 31S bugs and fixes - Bit - 12-17-2014, 12:55 AM
RE: WP 34S and 31S bugs and fixes - Bit - 12-23-2014, 04:03 AM
RE: WP 34S and 31S bugs and fixes - Bit - 12-23-2014, 01:23 PM
RE: WP 34S and 31S bugs and fixes - Bit - 12-23-2014, 04:48 AM
RE: WP 34S and 31S bugs and fixes - Bit - 12-23-2014, 01:38 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-01-2015, 10:42 PM
RE: WP 34S and 31S bugs and fixes - Bit - 12-24-2014, 01:11 PM
RE: WP 34S and 31S bugs and fixes - Bit - 12-24-2014, 04:36 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-08-2015, 03:04 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-08-2015, 04:34 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-08-2015, 05:28 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-09-2015, 12:32 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-09-2015, 12:38 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-10-2015, 06:28 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-17-2015, 04:50 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-18-2015, 03:42 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-18-2015, 05:32 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-18-2015, 06:47 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-18-2015, 08:54 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-18-2015, 09:12 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-18-2015, 09:37 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-11-2015, 05:07 AM
RE: WP 34S and 31S bugs and fixes - DMaier - 01-11-2015, 06:51 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-12-2015, 12:48 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-12-2015, 01:31 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-12-2015, 02:00 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-12-2015, 05:44 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-12-2015, 11:39 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-17-2015, 02:34 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-17-2015, 05:16 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-17-2015, 05:47 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-17-2015, 04:20 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-17-2015, 04:35 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-18-2015, 03:11 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-18-2015, 09:56 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-24-2015, 04:37 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-25-2015, 04:42 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-25-2015, 05:27 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-25-2015, 05:50 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-25-2015, 06:08 PM
RE: WP 34S and 31S bugs and fixes - Bit - 01-28-2015, 12:26 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-21-2015, 12:40 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-22-2015, 05:16 AM
RE: WP 34S and 31S bugs and fixes - Bit - 01-31-2015, 12:52 AM
RE: WP 34S and 31S bugs and fixes - Bit - 02-07-2015, 06:17 PM
RE: WP 34S and 31S bugs and fixes - Bit - 02-08-2015, 05:58 PM
RE: WP 34S and 31S bugs and fixes - Bit - 02-20-2015, 04:52 AM
RE: WP 34S and 31S bugs and fixes - Bit - 02-24-2015, 03:50 AM
RE: WP 34S and 31S bugs and fixes - Bit - 03-15-2015, 04:55 PM
RE: WP 34S and 31S bugs and fixes - Dieter - 03-15-2015, 10:41 PM
RE: WP 34S and 31S bugs and fixes - Bit - 03-15-2015, 10:50 PM
RE: WP 34S and 31S bugs and fixes - Pascal - 05-07-2015, 07:47 AM
RE: WP 34S and 31S bugs and fixes - fhub - 05-07-2015, 11:56 AM
RE: WP 34S and 31S bugs and fixes - fhub - 05-07-2015, 02:05 PM
RE: WP 34S and 31S bugs and fixes - fhub - 05-07-2015, 03:23 PM
RE: WP 34S and 31S bugs and fixes - fhub - 05-09-2015, 05:19 PM
RE: WP 34S and 31S bugs and fixes - Marcio - 06-10-2015, 07:06 AM
RE: WP 34S and 31S bugs and fixes - Marcio - 06-10-2015, 01:06 PM
RE: WP 34S and 31S bugs and fixes - 2far - 08-27-2015, 11:06 AM
RE: WP 34S and 31S bugs and fixes - 2far - 08-27-2015, 04:09 PM
RE: WP 34S and 31S bugs and fixes - 2far - 08-27-2015, 09:55 PM
RE: WP 34S and 31S bugs and fixes - fhub - 10-01-2015, 03:37 PM
RE: WP 34S and 31S bugs and fixes - d b - 10-02-2015, 03:21 AM
RE: WP 34S and 31S bugs and fixes - Pascal - 12-21-2015, 04:40 PM
RE: WP 34S and 31S bugs and fixes - Marcio - 12-21-2015, 08:41 PM
RE: WP 34S and 31S bugs and fixes - fhub - 12-22-2015, 10:39 AM
RE: WP 34S and 31S bugs and fixes - fhub - 12-22-2015, 01:20 PM
Moving off-screen window - striegel - 01-13-2016, 11:10 AM
RE: WP 34S and 31S bugs and fixes - fhub - 01-13-2016, 03:10 PM
RE: WP 34S and 31S bugs and fixes - Leonid - 02-04-2017, 06:48 AM
RE: WP 34S and 31S bugs and fixes - Nick - 02-07-2017, 02:47 PM
RE: WP 34S and 31S bugs and fixes - Leonid - 02-08-2017, 08:10 AM
RE: WP 34S and 31S bugs and fixes - Nick - 02-08-2017, 08:41 AM
RE: WP 34S and 31S bugs and fixes - vido - 02-07-2017, 08:00 AM
RE: WP 34S and 31S bugs and fixes - vido - 02-07-2017, 07:35 PM
RE: WP 34S and 31S bugs and fixes - Dieter - 05-23-2017, 12:19 PM
RE: WP 34S and 31S bugs and fixes - Dieter - 05-23-2017, 05:05 PM



User(s) browsing this thread: 1 Guest(s)