[SOLVED]here is a program that no longer works after FW10077 update
04-21-2016, 08:52 PM (This post was last modified: 04-23-2016 10:46 AM by dg1969.)
Post: #1
 dg1969 Member Posts: 117 Joined: Apr 2014
[SOLVED]here is a program that no longer works after FW10077 update
[EDIT] The solution was provided by Tim here: http://www.hpmuseum.org/forum/thread-6095.html

Hi,

I would like first to thank the whole team for this great work update.

It does not bother me to have to change the line of code if the current or future change brings simplifications ...

For exemple : Here is a program that no longer work...

Based on function app. The complete code is at the end of this post. It is a Bode plot program...

In the symb view place a transfert function in term of X for exemple 1/(1+X) and then press plot view key... The Bode gain plot works as before but the phase and step response fail...

I try to debug these function:

Code:
 export calcule_phases() BEGIN local k,j,r,retard; local f, a,num,denomi,cnum,cdenom,phi;   for k from 1 to length(liste_fonctions) do      if ISCHECK(k MOD 10) AND recalc_phase(k) then        f:=replace(string(liste_fonctions(k)),"X","x");        r:=instring(f,"e");        if r then                 retard:=right(f,size(f)-1-r);                 f:=left(f,r-2);        end;               a:=CAS.froot(f,"x");        num:=string(CAS.numer(f));        denomi:=string(CAS.denom(f));        cnum:=CAS.lcoeff(num,"x");        cdenom:=CAS.lcoeff(denomi,"x");        phi:=string(ARG(cnum/cdenom));         FOR j FROM 1 TO length(a) STEP 2 DO            IF RE(a(j))<>0 THEN                  phi:=phi+"+"+a(j+1)+"*ATAN(("+IM(a(j))+"-X)/("+RE(a(j))+"))";            ELSE IF a(j)==0 THEN                     phi:=phi+"+"+a(j+1)+"*90";                 ELSE phi:=phi+"+"+a(j+1)+"*90*SIGN(X-"+IM(a(j))+")";                 END;               END; //fin IF        END; //fin FOR j      if r then phi:=phi+"+"+replace(retard,"x","X") end;      phi:="'"+replace(phi,"X","ALOG(X)")+"'";     liste_phases(k):=EXPR(phi);     recalc_phase(k):=0;    end; //fin if ischek  end; //fin for k END;

After these line
Code:
 f:=replace(string(liste_fonctions(k)),"X","x");
f var contain the string "1/(1+x)"

The following lines do not work anymore..

Code:
 a:=CAS.froot(f,"x");        num:=string(CAS.numer(f));        denomi:=string(CAS.denom(f));        cnum:=CAS.lcoeff(num,"x");        cdenom:=CAS.lcoeff(denomi,"x");

In the HOME view i make some tests:

denom("1/(1+x)") => 1+x OK (no more CAS. prefixe when called from the catalog ?)

but if I first create a var with the same string f:="1/(1+x)"
then

denom(f) => 1 (wrong)...

May I have some help ?

I must say that these code pass the check test in the program editor when the digital grouping is set to the default dot but failled with the coma as digital grouping setting... What about the pragma on these new firmware ?

Thank's a lot for your help.

Didier

Here is the complete code of my Bode program

Code:
 #pragma mode( separator(.,;) integer(h64) ) copie_les_fonctions(); replace_les_fonctions(); place_les_modules(); place_les_phases(); place_les_rep_temp(); calcule_modules(); calcule_phases(); calcule_rep_temp(); Symb(); export liste_fonctions:=MAKELIST(0,X,1,10); export liste_modules:={}; export liste_phases:={}; export liste_rep_temp:={}; recalc_module:=MAKELIST(1,X,1,10); recalc_phase:=MAKELIST(1,X,1,10); recalc_temp:=MAKELIST(1,X,1,10); modif:=0; export copie_les_fonctions() begin   local k;   for k from 1 to 10 do     if ISCHECK(k MOD 10) then       if EVAL(EXPR("F"+k MOD 10)≠liste_fonctions(k)) then         IFERR liste_fonctions(k):=EXPR("F"+k MOD 10) then MSGBOX("Erreur de copie sur F"+k MOD 10) end;         recalc_module(k):=1;         recalc_phase(k):=1;         recalc_temp(k):=1;        end;      end;   end;   modif:=0; end; export replace_les_fonctions() begin   local k;   for k from 1 to length(liste_fonctions) do     if ISCHECK(k MOD 10) then         expr("F"+k MOD 10+":=liste_fonctions("+k+")");     end;   end; end; export place_les_modules() begin   local k;   for k from 1 to length(liste_modules) do      if ISCHECK(k MOD 10) then         expr("F"+k MOD 10+":=liste_modules("+k+")");      end;   end; end; export place_les_phases() begin   local k;   for k from 1 to length(liste_phases) do      if ISCHECK(k MOD 10) then        expr("F"+k MOD 10+":=liste_phases("+k+")");      end;   end; end; export place_les_rep_temp() begin   local k;   for k from 1 to length(liste_rep_temp) do      if ISCHECK(k MOD 10) then        expr("F"+k MOD 10+":=liste_rep_temp("+k+")");      end;   end; end; export calcule_modules() begin   local k;     for k from 1 to length(liste_fonctions) do        if ISCHECK(k MOD 10) AND recalc_module(k) then          liste_modules(k):=20*LOG(ABS(subst(liste_fonctions(k),'X','i*ALOG(X)')));          recalc_module(k):=0;         end;     end; end; export calcule_phases() BEGIN local k,j,r,retard; local f, a,num,denomi,cnum,cdenom,phi;   for k from 1 to length(liste_fonctions) do      if ISCHECK(k MOD 10) AND recalc_phase(k) then        f:=replace(string(liste_fonctions(k)),"X","x");        r:=instring(f,"e");        if r then                 retard:=right(f,size(f)-1-r);                 f:=left(f,r-2);        end;               a:=CAS.froot(f,"x");        num:=string(CAS.numer(f));        denomi:=string(CAS.denom(f));        cnum:=CAS.lcoeff(num,"x");        cdenom:=CAS.lcoeff(denomi,"x");        phi:=string(ARG(cnum/cdenom));         FOR j FROM 1 TO length(a) STEP 2 DO            IF RE(a(j))<>0 THEN                  phi:=phi+"+"+a(j+1)+"*ATAN(("+IM(a(j))+"-X)/("+RE(a(j))+"))";            ELSE IF a(j)==0 THEN                     phi:=phi+"+"+a(j+1)+"*90";                 ELSE phi:=phi+"+"+a(j+1)+"*90*SIGN(X-"+IM(a(j))+")";                 END;               END; //fin IF        END; //fin FOR j      if r then phi:=phi+"+"+replace(retard,"x","X") end;      phi:="'"+replace(phi,"X","ALOG(X)")+"'";     liste_phases(k):=EXPR(phi);     recalc_phase(k):=0;    end; //fin if ischek  end; //fin for k END; export calcule_rep_temp() begin    local f, k;      for k from 1 to length(liste_fonctions) do         if ISCHECK(k MOD 10) AND recalc_temp(k) then           f:=REPLACE(STRING(liste_fonctions(k)),"X","x");           f:=f+"*1/x,x,x";           f:="'("+REPLACE(STRING(CAS.ilaplace(f)),"x","X")+")*PIECEWISE(X<0,0,X≥0,1)'";           IF instring(f,"ilaplace")              THEN MSGBOX("Problème avec F"+k MOD 10); CONTINUE;             ELSE liste_rep_temp(k):=EXPR(f);           END;           recalc_temp(k):=0;         end;      end; end; Symb() begin   modif:=1;   replace_les_fonctions;   STARTVIEW(0,1); end; Plot() begin   local choix;   if modif then copie_les_fonctions end;   CHOOSE(choix,"Choisissez un type de tracé",{"Module","phase","réponse indicielle"});   CASE    IF choix==1 THEN calcule_modules; place_les_modules;Ytick:=20 END;    IF choix==2 THEN calcule_phases; place_les_phases;Ytick:=45 END;    IF choix==3 THEN calcule_rep_temp; place_les_rep_temp; Xmin:=−0.2 END;    //DEFAULT   END;   STARTVIEW(1,1); end; START() begin  modif:=1;  replace_les_fonctions;  STARTVIEW(0,1); end;
 « Next Oldest | Next Newest »

 Messages In This Thread [SOLVED]here is a program that no longer works after FW10077 update - dg1969 - 04-21-2016 08:52 PM RE: here is a program that no longer works after FW10077 update - Anderson Costa - 04-21-2016, 08:58 PM RE: here is a program that no longer works after FW10077 update - salvomic - 04-21-2016, 09:08 PM RE: here is a program that no longer works after FW10077 update - Anderson Costa - 04-21-2016, 09:12 PM RE: here is a program that no longer works after FW10077 update - salvomic - 04-21-2016, 09:18 PM RE: here is a program that no longer works after FW10077 update - mandresve - 04-21-2016, 09:14 PM RE: here is a program that no longer works after FW10077 update - Anderson Costa - 04-21-2016, 09:25 PM RE: here is a program that no longer works after FW10077 update - salvomic - 04-21-2016, 09:26 PM RE: here is a program that no longer works after FW10077 update - akmon - 04-21-2016, 09:18 PM RE: here is a program that no longer works after FW10077 update - akmon - 04-21-2016, 09:39 PM RE: here is a program that no longer works after FW10077 update - salvomic - 04-21-2016, 09:57 PM RE: here is a program that no longer works after FW10077 update - Mic - 04-22-2016, 05:11 AM RE: here is a program that no longer works after FW10077 update - Tim Wessman - 04-22-2016, 05:19 AM RE: here is a program that no longer works after FW10077 update - Mic - 04-22-2016, 10:55 AM RE: here is a program that no longer works after FW10077 update - Tim Wessman - 04-22-2016, 02:57 PM

User(s) browsing this thread: 1 Guest(s)