Trying to improve x49gp

[gwh]

(12-02-2021 02:39 PM)Claudio L. Wrote:  I noticed Eric uploaded the bootloaders, so I tested the script and worked flawlessly.

Now as far as the Makefile, the pull request I received tries to fix the folders, but we really need to remove all references to the firmware from the Makefile. The Makefile should NEVER pull binaries, that needs to be left for the post-installation script of the package.

If the user is building directly from sources, then the user needs to manually run pull-roms.sh afterwards. If installing via apt/yum, etc. then the package should automatically run the script after installing x49gp.

It's important for 2 things:
* Building x49gp should not depend on whether those binaries are available or not.
* Binaries need to be pulled by the final user, not the person building the package.

I confirm that the pull-roms.sh works now that hpcalc.org has all the files.

Concerning the Makefile: if I understand correctly, building x49gp doesn't require the bootloaders binaries. It only needs to be documented that these bootloaders binaries are needed at runtime, where to find them (hpcalc.org url) and where to install them ( $PREFIX/share/x49gp/ .) The rest is the packager's concern.

I'd go as far as copying pull-roms.sh to $PREFIX/usr/doc/x49gp/ or $PREFIX/usr/share/x49gp/

Main concern is that

Code:

make install

then installs a non-functional software without manual action from the user (as root) but maybe that concerns a tiny minority.