WP 34S and 31S bugs and fixes

[Bit]

(01-08-2015 04:48 AM)walter b Wrote:  

(01-08-2015 04:34 AM)Bit Wrote:  The YDON and YDOFF commands were included in the 34S and 31S even if Y register display was completely disabled at compile time. I've fixed that ...

Thanks a lot for your work in bug hunting. Much appreciated.

d:-)

You're welcome.

There's more:

1. Incomplete or invalid fractions cause delayed error messages
   If you type in an incomplete fraction (a ^b/_nothing) or an invalid fraction (a ^b/₀) and then enter a catalog or perform another operation that immediately changes the display, the error message caused by the bad fraction will appear after the operation that follows the catalog (or similar) activity.
   
   Here's how to reproduce the problem:
   [1] [.] [2] [.] [h] [MODE] [EXIT] [+] -> Domain error
   Funnier:
   [1] [.] [2] [.] [h] [MODE] [EXIT] [1] -> Domain error
   Also:
   [1] [.] [2] [.] [h] [P/R] (program away...) [EXIT] [R/S] -> Domain error
   And so on. If double-dot fractions (a..b -> a/b) are enabled, they have the same problem.
   
   I've created a patch that produces similar behavior as that of the 35S: You get an error message immediately if you try to perform any operation with an invalid command line. (The only exception is turning off the calculator, which always succeeds.)
   
   
2. CLx produces domain error if the command line contains a bad fraction
   CLx always clears the command line but still produces a domain error if an incomplete or invalid fraction was entered. This makes little sense in my opinion since the bad input that CLx complains about was never used. I suggest that CLx silently clear the command line.
   
   
3. EEX not allowed in fractions mode even if no fraction was entered
   The specials() function in xeq.c disables EEX in integer modes or whenever a fraction is being entered, which makes sense. However, it also disables EEX in fractions mode even if no fraction was entered. That looks to me like an oversight (I couldn't find anything about it in the documentation) and I suggest we allow exponent entry in fractions mode as long as no fraction is being entered (the 35S does the same).
   

I have patches ready for all three issues.

Walter, could you please comment on whether you think my proposed fixes should be committed, or if you'd like some other behavior?