WP 34S and 31S bugs and fixes

[Bit]

(01-23-2015 11:37 PM)walter b Wrote:  

(01-18-2015 09:56 PM)Bit Wrote:  ... the output of the DECOMP command on the top of page 86 of 374 in the latest printed manual (3.3) is different from what the calculator shows. In the manual it's "x/y >", but in the real device it's "x/y Gt".

I suggest we change the calculator to agree with the manual. The Y register display already uses < and > instead of Lt and Gt because space is tight. This way DECOMP would be consistent with that as well. Please comment.

Hmmh. The latest emulator build shows "y/x Gt", being consistent with the stack contents. I agree on using ">" instead of "Gt" in the dot matrix display. "Gt" was just meant to be used in the exponent section.

d:-)

It's indeed y/x. I've committed a patch.

Another minor issue:

After you press the arrow, you can deactivate all shift modes or activate h shift, even though neither makes much sense in 'arrow mode'. The code that handles the arrow (process_arrow() in keys.c) was clearly written to operate in way similar to 'HYP mode' where only the f or g shifts are allowed. It only checks for f shift, thus anything else, g shift, h shift or no shift, all produce the same result: effectively g shift.

For example, [->] [h] [EEX] will show the number in hexadecimal.

I suggest we make the arrow work the same as HYP: only the f and g shifts should be allowed.